Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the useless target install-all #3226

Merged
merged 5 commits into from
Nov 12, 2021

Conversation

yixinglu
Copy link
Contributor

This target will result in executable error when running sudo make install-all and could be replaced with make install.

image

introduced in #3195

This will result in executable error when running `sudo make install-all`
@yixinglu yixinglu added ready-for-testing PR: ready for the CI test doc affected PR: improvements or additions to documentation labels Oct 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #3226 (d6c1d48) into master (58f0b44) will increase coverage by 0.02%.
The diff coverage is 87.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3226      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.02%     
==========================================
  Files        1295     1305      +10     
  Lines      118190   120388    +2198     
==========================================
+ Hits       100748   102653    +1905     
- Misses      17442    17735     +293     
Impacted Files Coverage Δ
src/clients/storage/GraphStorageClient.cpp 73.29% <0.00%> (-3.05%) ⬇️
src/clients/storage/GraphStorageClient.h 100.00% <ø> (ø)
src/clients/storage/StorageClientBase-inl.h 72.34% <0.00%> (-5.83%) ⬇️
src/clients/storage/StorageClientBase.h 65.57% <ø> (+4.03%) ⬆️
src/storage/ExprVisitorBase.h 0.00% <0.00%> (ø)
src/storage/exec/RelNode.h 79.06% <ø> (-18.61%) ⬇️
src/storage/exec/StorageIterator.h 94.33% <ø> (+5.45%) ⬆️
src/storage/query/ScanEdgeProcessor.h 100.00% <ø> (ø)
src/storage/query/ScanVertexProcessor.h 100.00% <ø> (ø)
src/storage/test/LookupIndexTest.cpp 100.00% <ø> (ø)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0028f...d6c1d48. Read the comment docs.

@jackwener jackwener requested review from jackwener and removed request for jackwener November 2, 2021 05:49
@jievince
Copy link
Contributor

jievince commented Nov 11, 2021

We may need the target graphd, metad and `storaged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants